-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(interceptor): allow wildcard securedRoutes #2080
feat(interceptor): allow wildcard securedRoutes #2080
Conversation
Docs are still missing. Will have a look at that later. And maybe you have a better idea regex wise so that we can combine startWith into the regex. But I wasn't able to find one yet that matched all test cases |
@FabianGosebrink added the documentation. Can you please check if you think this is sufficient. Also I'm interested on your thoughts about the regex check. Do you have an idea if there is a nice regex that would fit both cases, so we don't need the startWith comparison? I'm not a huge regex expert and didn't manage to find anything suitable yet. |
Hey thanks for your PR. Docs are fine. Also not a Regex Expert, but would something like this work?
|
I refactored a bit and tried to improve the regex. Can you have a look, give me your "OK" and then we can emrgen :-) |
@damienbod : Waiting for @skatterwe :-) |
@FabianGosebrink sorry was away for a while. looks fine to me |
No worries. Can you resolve the conflicts? Should only be ESLint stuff. |
# Conflicts: # projects/angular-auth-oidc-client/src/lib/interceptor/closest-matching-route.service.spec.ts
@FabianGosebrink done |
Awesome, thanks! |
I'll make a minor release for this |
enables wildcards for secureRoute configuration.
Fixes #2079