Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to new value #4372

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

elena-kolevska
Copy link
Contributor

@elena-kolevska elena-kolevska commented Oct 7, 2024

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

During code review it was decided the value should be changed in Dapr, so this PR updates the docs. I'll mark this PR as ready for review as soon as the code PR gets merged.

Signed-off-by: Elena Kolevska <[email protected]>
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elena-kolevska elena-kolevska marked this pull request as ready for review October 11, 2024 14:50
@elena-kolevska elena-kolevska requested review from a team as code owners October 11, 2024 14:50
@elena-kolevska
Copy link
Contributor Author

The code PR got merged, we can now merge the docs PR.

Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Oct 17, 2024
@hhunter-ms hhunter-ms merged commit 1bf6bd7 into dapr:v1.15 Oct 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants