Fix inconsistency between package list and package page copy icon opa…

…cities.
dart-lang · Feb 12, 2025 · ed21b49 · ed21b49
1 parent 1b9b75b
commit ed21b49
Show file tree

Hide file tree

Showing 44 changed files with 55 additions and 62 deletions.
diff --git a/app/lib/frontend/templates/views/pkg/package_list.dart b/app/lib/frontend/templates/views/pkg/package_list.dart
@@ -225,7 +225,8 @@ d.Node _item({
         classes: ['packages-header'],
         children: [
           d.h3(classes: [
-            'packages-title'
+            'packages-title',
+            'pub-monochrome-icon-hoverable',
           ], children: [
             d.a(href: url, text: name),
             if (copyIcon != null) copyIcon,

diff --git a/app/lib/frontend/templates/views/shared/detail/header.dart b/app/lib/frontend/templates/views/shared/detail/header.dart
@@ -111,7 +111,10 @@ d.Node detailHeaderNode({
             d.div(
               classes: ['detail-header-content-block'],
               children: [
-                d.h1(classes: ['title'], child: titleNode),
+                d.h1(
+                  classes: ['title', 'pub-monochrome-icon-hoverable'],
+                  child: titleNode,
+                ),
                 d.div(classes: ['metadata'], child: metadataNode),
                 if (tagsNode != null || likeCount != null)
                   d.div(

diff --git a/app/test/frontend/golden/my_activity_log_page.html b/app/test/frontend/golden/my_activity_log_page.html
@@ -142,7 +142,7 @@ <h3 class="foldable-button">
                 <img class="detail-header-image" src="https://www.gravatar.com/avatar/92c525024f1911332fe1d0f7dd750977?d=retro&amp;s=200=s400" alt="user profile picture" width="200" height="200"/>
               </div>
               <div class="detail-header-content-block">
-                <h1 class="title">admin</h1>
+                <h1 class="title pub-monochrome-icon-hoverable">admin</h1>
                 <div class="metadata">
                   <p>[email protected]</p>
                   <p>

diff --git a/app/test/frontend/golden/my_liked_packages.html b/app/test/frontend/golden/my_liked_packages.html
@@ -143,7 +143,7 @@ <h3 class="foldable-button">
                 <img class="detail-header-image" src="https://www.gravatar.com/avatar/f1983c9193966b63c29c141c02db9a34?d=retro&amp;s=200=s400" alt="user profile picture" width="200" height="200"/>
               </div>
               <div class="detail-header-content-block">
-                <h1 class="title">user</h1>
+                <h1 class="title pub-monochrome-icon-hoverable">user</h1>
                 <div class="metadata">
                   <p>[email protected]</p>
                   <p>

diff --git a/app/test/frontend/golden/my_packages.html b/app/test/frontend/golden/my_packages.html
@@ -142,7 +142,7 @@ <h3 class="foldable-button">
                 <img class="detail-header-image" src="https://www.gravatar.com/avatar/f1983c9193966b63c29c141c02db9a34?d=retro&amp;s=200=s400" alt="user profile picture" width="200" height="200"/>
               </div>
               <div class="detail-header-content-block">
-                <h1 class="title">user</h1>
+                <h1 class="title pub-monochrome-icon-hoverable">user</h1>
                 <div class="metadata">
                   <p>[email protected]</p>
                   <p>
@@ -183,7 +183,7 @@ <h1 class="title">user</h1>
                   <div class="packages">
                     <div class="packages-item">
                       <div class="packages-header">
-                        <h3 class="packages-title">
+                        <h3 class="packages-title pub-monochrome-icon-hoverable">
                           <a href="/packages/oxygen">oxygen</a>
                           <span class="pkg-page-title-copy">
                             <img class="pub-monochrome-icon pkg-page-title-copy-icon filter-invert-on-dark" src="/static/hash-%%etag%%/img/content-copy-icon.svg" alt="copy &quot;oxygen: ^1.2.0&quot; to clipboard" width="18" height="18" title="Copy &quot;oxygen: ^1.2.0&quot; to clipboard" data-copy-content="oxygen: ^1.2.0" data-ga-click-event="copy-package-version"/>
@@ -266,7 +266,7 @@ <h3 class="packages-title">
                     </div>
                     <div class="packages-item">
                       <div class="packages-header">
-                        <h3 class="packages-title">
+                        <h3 class="packages-title pub-monochrome-icon-hoverable">
                           <a href="/packages/neon">neon</a>
                           <span class="pkg-page-title-copy">
                             <img class="pub-monochrome-icon pkg-page-title-copy-icon filter-invert-on-dark" src="/static/hash-%%etag%%/img/content-copy-icon.svg" alt="copy &quot;neon: ^1.0.0&quot; to clipboard" width="18" height="18" title="Copy &quot;neon: ^1.0.0&quot; to clipboard" data-copy-content="neon: ^1.0.0" data-ga-click-event="copy-package-version"/>

diff --git a/app/test/frontend/golden/my_publishers.html b/app/test/frontend/golden/my_publishers.html
@@ -142,7 +142,7 @@ <h3 class="foldable-button">
                 <img class="detail-header-image" src="https://www.gravatar.com/avatar/f1983c9193966b63c29c141c02db9a34?d=retro&amp;s=200=s400" alt="user profile picture" width="200" height="200"/>
               </div>
               <div class="detail-header-content-block">
-                <h1 class="title">user</h1>
+                <h1 class="title pub-monochrome-icon-hoverable">user</h1>
                 <div class="metadata">
                   <p>[email protected]</p>
                   <p>

diff --git a/app/test/frontend/golden/pkg_activity_log_page.html b/app/test/frontend/golden/pkg_activity_log_page.html
@@ -141,7 +141,7 @@ <h3 class="foldable-button">
           <div class="detail-container">
             <div class="detail-header-outer-block">
               <div class="detail-header-content-block">
-                <h1 class="title">
+                <h1 class="title pub-monochrome-icon-hoverable">
                   oxygen 1.2.0
                   <span class="pkg-page-title-copy">
                     <img class="pub-monochrome-icon pkg-page-title-copy-icon filter-invert-on-dark" src="/static/hash-%%etag%%/img/content-copy-icon.svg" alt="copy &quot;oxygen: ^1.2.0&quot; to clipboard" width="18" height="18" title="Copy &quot;oxygen: ^1.2.0&quot; to clipboard" data-copy-content="oxygen: ^1.2.0" data-ga-click-event="copy-package-version"/>

diff --git a/app/test/frontend/golden/pkg_admin_page.html b/app/test/frontend/golden/pkg_admin_page.html
@@ -141,7 +141,7 @@ <h3 class="foldable-button">
           <div class="detail-container">
             <div class="detail-header-outer-block">
               <div class="detail-header-content-block">
-                <h1 class="title">
+                <h1 class="title pub-monochrome-icon-hoverable">
                   oxygen 1.2.0
                   <span class="pkg-page-title-copy">
                     <img class="pub-monochrome-icon pkg-page-title-copy-icon filter-invert-on-dark" src="/static/hash-%%etag%%/img/content-copy-icon.svg" alt="copy &quot;oxygen: ^1.2.0&quot; to clipboard" width="18" height="18" title="Copy &quot;oxygen: ^1.2.0&quot; to clipboard" data-copy-content="oxygen: ^1.2.0" data-ga-click-event="copy-package-version"/>

diff --git a/app/test/frontend/golden/pkg_changelog_page.html b/app/test/frontend/golden/pkg_changelog_page.html
@@ -115,7 +115,7 @@ <h3 class="foldable-button">
           <div class="detail-container">
             <div class="detail-header-outer-block">
               <div class="detail-header-content-block">
-                <h1 class="title">
+                <h1 class="title pub-monochrome-icon-hoverable">
                   oxygen 1.2.0
                   <span class="pkg-page-title-copy">
                     <img class="pub-monochrome-icon pkg-page-title-copy-icon filter-invert-on-dark" src="/static/hash-%%etag%%/img/content-copy-icon.svg" alt="copy &quot;oxygen: ^1.2.0&quot; to clipboard" width="18" height="18" title="Copy &quot;oxygen: ^1.2.0&quot; to clipboard" data-copy-content="oxygen: ^1.2.0" data-ga-click-event="copy-package-version"/>

diff --git a/app/test/frontend/golden/pkg_example_page.html b/app/test/frontend/golden/pkg_example_page.html
@@ -115,7 +115,7 @@ <h3 class="foldable-button">
           <div class="detail-container">
             <div class="detail-header-outer-block">
               <div class="detail-header-content-block">
-                <h1 class="title">
+                <h1 class="title pub-monochrome-icon-hoverable">
                   oxygen 1.2.0
                   <span class="pkg-page-title-copy">
                     <img class="pub-monochrome-icon pkg-page-title-copy-icon filter-invert-on-dark" src="/static/hash-%%etag%%/img/content-copy-icon.svg" alt="copy &quot;oxygen: ^1.2.0&quot; to clipboard" width="18" height="18" title="Copy &quot;oxygen: ^1.2.0&quot; to clipboard" data-copy-content="oxygen: ^1.2.0" data-ga-click-event="copy-package-version"/>

diff --git a/app/test/frontend/golden/pkg_index_page.html b/app/test/frontend/golden/pkg_index_page.html
@@ -431,7 +431,7 @@ <h3 class="search-form-section-header foldable-button">
           <div class="packages">
             <div class="packages-item">
               <div class="packages-header">
-                <h3 class="packages-title">
+                <h3 class="packages-title pub-monochrome-icon-hoverable">
                   <a href="https://api.dart.dev/library-page.html">dart:core</a>
                 </h3>
               </div>
@@ -450,7 +450,7 @@ <h3 class="packages-title">
             </div>
             <div class="packages-item">
               <div class="packages-header">
-                <h3 class="packages-title">
+                <h3 class="packages-title pub-monochrome-icon-hoverable">
                   <a href="/packages/oxygen">oxygen</a>
                   <span class="pkg-page-title-copy">
                     <img class="pub-monochrome-icon pkg-page-title-copy-icon filter-invert-on-dark" src="/static/hash-%%etag%%/img/content-copy-icon.svg" alt="copy &quot;oxygen: ^1.2.0&quot; to clipboard" width="18" height="18" title="Copy &quot;oxygen: ^1.2.0&quot; to clipboard" data-copy-content="oxygen: ^1.2.0" data-ga-click-event="copy-package-version"/>
@@ -533,7 +533,7 @@ <h3 class="packages-title">
             </div>
             <div class="packages-item">
               <div class="packages-header">
-                <h3 class="packages-title">
+                <h3 class="packages-title pub-monochrome-icon-hoverable">
                   <a href="/packages/flutter_titanium">flutter_titanium</a>
                   <span class="pkg-page-title-copy">
                     <img class="pub-monochrome-icon pkg-page-title-copy-icon filter-invert-on-dark" src="/static/hash-%%etag%%/img/content-copy-icon.svg" alt="copy &quot;flutter_titanium: ^1.10.0&quot; to clipboard" width="18" height="18" title="Copy &quot;flutter_titanium: ^1.10.0&quot; to clipboard" data-copy-content="flutter_titanium: ^1.10.0" data-ga-click-event="copy-package-version"/>

diff --git a/app/test/frontend/golden/pkg_install_page.html b/app/test/frontend/golden/pkg_install_page.html
@@ -115,7 +115,7 @@ <h3 class="foldable-button">
           <div class="detail-container">
             <div class="detail-header-outer-block">
               <div class="detail-header-content-block">
-                <h1 class="title">
+                <h1 class="title pub-monochrome-icon-hoverable">
                   oxygen 1.2.0
                   <span class="pkg-page-title-copy">
                     <img class="pub-monochrome-icon pkg-page-title-copy-icon filter-invert-on-dark" src="/static/hash-%%etag%%/img/content-copy-icon.svg" alt="copy &quot;oxygen: ^1.2.0&quot; to clipboard" width="18" height="18" title="Copy &quot;oxygen: ^1.2.0&quot; to clipboard" data-copy-content="oxygen: ^1.2.0" data-ga-click-event="copy-package-version"/>

diff --git a/app/test/frontend/golden/pkg_score_page.html b/app/test/frontend/golden/pkg_score_page.html
@@ -115,7 +115,7 @@ <h3 class="foldable-button">
           <div class="detail-container">
             <div class="detail-header-outer-block">
               <div class="detail-header-content-block">
-                <h1 class="title">
+                <h1 class="title pub-monochrome-icon-hoverable">
                   oxygen 1.2.0
                   <span class="pkg-page-title-copy">
                     <img class="pub-monochrome-icon pkg-page-title-copy-icon filter-invert-on-dark" src="/static/hash-%%etag%%/img/content-copy-icon.svg" alt="copy &quot;oxygen: ^1.2.0&quot; to clipboard" width="18" height="18" title="Copy &quot;oxygen: ^1.2.0&quot; to clipboard" data-copy-content="oxygen: ^1.2.0" data-ga-click-event="copy-package-version"/>

diff --git a/app/test/frontend/golden/pkg_score_page_with_downloads_chart.html b/app/test/frontend/golden/pkg_score_page_with_downloads_chart.html
@@ -115,7 +115,7 @@ <h3 class="foldable-button">
           <div class="detail-container">
             <div class="detail-header-outer-block">
               <div class="detail-header-content-block">
-                <h1 class="title">
+                <h1 class="title pub-monochrome-icon-hoverable">
                   oxygen 1.2.0
                   <span class="pkg-page-title-copy">
                     <img class="pub-monochrome-icon pkg-page-title-copy-icon filter-invert-on-dark" src="/static/hash-%%etag%%/img/content-copy-icon.svg" alt="copy &quot;oxygen: ^1.2.0&quot; to clipboard" width="18" height="18" title="Copy &quot;oxygen: ^1.2.0&quot; to clipboard" data-copy-content="oxygen: ^1.2.0" data-ga-click-event="copy-package-version"/>

diff --git a/app/test/frontend/golden/pkg_show_page.html b/app/test/frontend/golden/pkg_show_page.html
@@ -115,7 +115,7 @@ <h3 class="foldable-button">
           <div class="detail-container">
             <div class="detail-header-outer-block">
               <div class="detail-header-content-block">
-                <h1 class="title">
+                <h1 class="title pub-monochrome-icon-hoverable">
                   oxygen 1.2.0
                   <span class="pkg-page-title-copy">
                     <img class="pub-monochrome-icon pkg-page-title-copy-icon filter-invert-on-dark" src="/static/hash-%%etag%%/img/content-copy-icon.svg" alt="copy &quot;oxygen: ^1.2.0&quot; to clipboard" width="18" height="18" title="Copy &quot;oxygen: ^1.2.0&quot; to clipboard" data-copy-content="oxygen: ^1.2.0" data-ga-click-event="copy-package-version"/>

diff --git a/app/test/frontend/golden/pkg_show_page_discontinued.html b/app/test/frontend/golden/pkg_show_page_discontinued.html
@@ -115,7 +115,7 @@ <h3 class="foldable-button">
           <div class="detail-container">
             <div class="detail-header-outer-block">
               <div class="detail-header-content-block">
-                <h1 class="title">
+                <h1 class="title pub-monochrome-icon-hoverable">
                   pkg 1.0.0
                   <span class="pkg-page-title-copy">
                     <img class="pub-monochrome-icon pkg-page-title-copy-icon filter-invert-on-dark" src="/static/hash-%%etag%%/img/content-copy-icon.svg" alt="copy &quot;pkg: ^1.0.0&quot; to clipboard" width="18" height="18" title="Copy &quot;pkg: ^1.0.0&quot; to clipboard" data-copy-content="pkg: ^1.0.0" data-ga-click-event="copy-package-version"/>

diff --git a/app/test/frontend/golden/pkg_show_page_flutter_plugin.html b/app/test/frontend/golden/pkg_show_page_flutter_plugin.html
@@ -115,7 +115,7 @@ <h3 class="foldable-button">
           <div class="detail-container">
             <div class="detail-header-outer-block">
               <div class="detail-header-content-block">
-                <h1 class="title">
+                <h1 class="title pub-monochrome-icon-hoverable">
                   flutter_titanium 1.10.0
                   <span class="pkg-page-title-copy">
                     <img class="pub-monochrome-icon pkg-page-title-copy-icon filter-invert-on-dark" src="/static/hash-%%etag%%/img/content-copy-icon.svg" alt="copy &quot;flutter_titanium: ^1.10.0&quot; to clipboard" width="18" height="18" title="Copy &quot;flutter_titanium: ^1.10.0&quot; to clipboard" data-copy-content="flutter_titanium: ^1.10.0" data-ga-click-event="copy-package-version"/>

diff --git a/app/test/frontend/golden/pkg_show_page_publisher.html b/app/test/frontend/golden/pkg_show_page_publisher.html
@@ -115,7 +115,7 @@ <h3 class="foldable-button">
           <div class="detail-container">
             <div class="detail-header-outer-block">
               <div class="detail-header-content-block">
-                <h1 class="title">
+                <h1 class="title pub-monochrome-icon-hoverable">
                   neon 1.0.0
                   <span class="pkg-page-title-copy">
                     <img class="pub-monochrome-icon pkg-page-title-copy-icon filter-invert-on-dark" src="/static/hash-%%etag%%/img/content-copy-icon.svg" alt="copy &quot;neon: ^1.0.0&quot; to clipboard" width="18" height="18" title="Copy &quot;neon: ^1.0.0&quot; to clipboard" data-copy-content="neon: ^1.0.0" data-ga-click-event="copy-package-version"/>

diff --git a/app/test/frontend/golden/pkg_show_page_retracted.html b/app/test/frontend/golden/pkg_show_page_retracted.html
@@ -115,7 +115,7 @@ <h3 class="foldable-button">
           <div class="detail-container">
             <div class="detail-header-outer-block">
               <div class="detail-header-content-block">
-                <h1 class="title">
+                <h1 class="title pub-monochrome-icon-hoverable">
                   pkg 1.0.0
                   <span class="pkg-page-title-copy">
                     <img class="pub-monochrome-icon pkg-page-title-copy-icon filter-invert-on-dark" src="/static/hash-%%etag%%/img/content-copy-icon.svg" alt="copy &quot;pkg: ^1.0.0&quot; to clipboard" width="18" height="18" title="Copy &quot;pkg: ^1.0.0&quot; to clipboard" data-copy-content="pkg: ^1.0.0" data-ga-click-event="copy-package-version"/>

diff --git a/app/test/frontend/golden/pkg_show_page_retracted_non_retracted_version.html b/app/test/frontend/golden/pkg_show_page_retracted_non_retracted_version.html
@@ -115,7 +115,7 @@ <h3 class="foldable-button">
           <div class="detail-container">
             <div class="detail-header-outer-block">
               <div class="detail-header-content-block">
-                <h1 class="title">
+                <h1 class="title pub-monochrome-icon-hoverable">
                   pkg 2.0.0
                   <span class="pkg-page-title-copy">
                     <img class="pub-monochrome-icon pkg-page-title-copy-icon filter-invert-on-dark" src="/static/hash-%%etag%%/img/content-copy-icon.svg" alt="copy &quot;pkg: ^2.0.0&quot; to clipboard" width="18" height="18" title="Copy &quot;pkg: ^2.0.0&quot; to clipboard" data-copy-content="pkg: ^2.0.0" data-ga-click-event="copy-package-version"/>

diff --git a/app/test/frontend/golden/pkg_show_version_page.html b/app/test/frontend/golden/pkg_show_version_page.html
@@ -115,7 +115,7 @@ <h3 class="foldable-button">
           <div class="detail-container">
             <div class="detail-header-outer-block">
               <div class="detail-header-content-block">
-                <h1 class="title">
+                <h1 class="title pub-monochrome-icon-hoverable">
                   oxygen 1.2.0
                   <span class="pkg-page-title-copy">
                     <img class="pub-monochrome-icon pkg-page-title-copy-icon filter-invert-on-dark" src="/static/hash-%%etag%%/img/content-copy-icon.svg" alt="copy &quot;oxygen: ^1.2.0&quot; to clipboard" width="18" height="18" title="Copy &quot;oxygen: ^1.2.0&quot; to clipboard" data-copy-content="oxygen: ^1.2.0" data-ga-click-event="copy-package-version"/>

diff --git a/app/test/frontend/golden/pkg_versions_page.html b/app/test/frontend/golden/pkg_versions_page.html
@@ -115,7 +115,7 @@ <h3 class="foldable-button">
           <div class="detail-container">
             <div class="detail-header-outer-block">
               <div class="detail-header-content-block">
-                <h1 class="title">
+                <h1 class="title pub-monochrome-icon-hoverable">
                   oxygen 1.2.0
                   <span class="pkg-page-title-copy">
                     <img class="pub-monochrome-icon pkg-page-title-copy-icon filter-invert-on-dark" src="/static/hash-%%etag%%/img/content-copy-icon.svg" alt="copy &quot;oxygen: ^1.2.0&quot; to clipboard" width="18" height="18" title="Copy &quot;oxygen: ^1.2.0&quot; to clipboard" data-copy-content="oxygen: ^1.2.0" data-ga-click-event="copy-package-version"/>

diff --git a/app/test/frontend/golden/publisher_activity_log_page.html b/app/test/frontend/golden/publisher_activity_log_page.html
@@ -117,7 +117,7 @@ <h3 class="foldable-button">
           <div class="detail-container">
             <div class="detail-header-outer-block">
               <div class="detail-header-content-block">
-                <h1 class="title">example.com</h1>
+                <h1 class="title pub-monochrome-icon-hoverable">example.com</h1>
                 <div class="metadata">
                   <p>
                     <span class="detail-header-metadata-ref">

diff --git a/app/test/frontend/golden/publisher_admin_page.html b/app/test/frontend/golden/publisher_admin_page.html
@@ -117,7 +117,7 @@ <h3 class="foldable-button">
           <div class="detail-container">
             <div class="detail-header-outer-block">
               <div class="detail-header-content-block">
-                <h1 class="title">example.com</h1>
+                <h1 class="title pub-monochrome-icon-hoverable">example.com</h1>
                 <div class="metadata">
                   <p>
                     <span class="detail-header-metadata-ref">