Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darker Flutter Favorite logos for dark mode. #8524

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Feb 3, 2025

The separate image diffs are below, before/after in context:
image
image

Note: This was done via pixel color manipulation in gimp, and it is likely we should get a designer to re-do the logos with proper vectorized assets.

@isoos isoos requested review from jonasfj and sigurdm February 3, 2025 15:56
@isoos
Copy link
Collaborator Author

isoos commented Feb 3, 2025

/cc @parlough

Also: this is now on staging.

@sigurdm
Copy link
Contributor

sigurdm commented Feb 4, 2025

I like the slightly darker background of the logo - but to me the contrast of the text is now to small.

@isoos
Copy link
Collaborator Author

isoos commented Feb 4, 2025

I like the slightly darker background of the logo - but to me the contrast of the text is now to small.

I have done couple of iterations, but I can't really keep the contrast up, it is a dark text after all. Especially not with this pixelated version of the logo... Let's keep it as-is then?

@sigurdm
Copy link
Contributor

sigurdm commented Feb 4, 2025

Maybe the text should now be brighter than the surface?

@isoos
Copy link
Collaborator Author

isoos commented Feb 4, 2025

Maybe the text should now be brighter than the surface?

Yeah, but my gimp skills are not enough to brighten it to an acceptable level of text readability with these pixel version logo. In other words: what I got was really ugly.

@isoos
Copy link
Collaborator Author

isoos commented Feb 4, 2025

@sigurdm: Updated the image, slightly darker background than currently, also turning the label text color down. wdyt?

@sigurdm
Copy link
Contributor

sigurdm commented Feb 4, 2025

I like it!

@isoos isoos merged commit cc830bd into dart-lang:master Feb 4, 2025
31 checks passed
@isoos isoos deleted the ff-logo branch February 4, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants