Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CSS font variables. #8534

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Rename CSS font variables. #8534

merged 1 commit into from
Feb 7, 2025

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Feb 6, 2025

  • I think the font-families are rather similar to --pub-color-<x>, we should define them as --pub-font-family-<x>.
  • Dropping the default- part, as I don't think we will have too many different cases.
  • Using body instead of default, I think it reads better.

@isoos isoos requested review from jonasfj and sigurdm February 6, 2025 16:39
@isoos
Copy link
Collaborator Author

isoos commented Feb 6, 2025

/cc @parlough

@isoos isoos merged commit 169bb69 into dart-lang:master Feb 7, 2025
31 checks passed
@isoos isoos deleted the font-variables branch February 7, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants