Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pub-monochrome-icon in the package title's copy icon. #8542

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Use pub-monochrome-icon in the package title's copy icon. #8542

merged 1 commit into from
Feb 7, 2025

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Feb 7, 2025

  • Fixes [Dark mode] Package ID copy button is too dark #8536
  • Expanded monochrome icon style to also include focus and transition.
  • Using CSS variable to control opacity, so that components that want to have different opacity ranges doesn't need to repeat all the hover/focus rules, though in this case we still need the title as parent (may be refactored in the future).

Before:
image
image

After:
image
image

Before:
image
image

After:
image
image

@isoos isoos requested review from jonasfj and sigurdm February 7, 2025 13:12
@isoos
Copy link
Collaborator Author

isoos commented Feb 7, 2025

Note: staging deployment is ongoing.

@isoos isoos merged commit 4961396 into dart-lang:master Feb 7, 2025
32 checks passed
@isoos isoos deleted the title-copy branch February 7, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigurdm sigurdm sigurdm approved these changes

@jonasfj jonasfj Awaiting requested review from jonasfj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dark mode] Package ID copy button is too dark
2 participants
@isoos @sigurdm