Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underline links on hover by default #8544

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

parlough
Copy link
Member

@parlough parlough commented Feb 7, 2025

dart.dev and docs.flutter.dev updated to do this for most links as well to meet the requirement of using more than color to distinguish link interactivity.

Resolves #7391

@isoos
Copy link
Collaborator

isoos commented Feb 10, 2025

Note: this is on staging right now.

@isoos isoos requested a review from jonasfj February 10, 2025 08:30
@isoos
Copy link
Collaborator

isoos commented Feb 10, 2025

I've found the underline a bit harsh - I guess I'm used to using the site without it. Maybe we could have a different underline color using https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration-color ?

Copy link
Member

@jonasfj jonasfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's land this after the release on Wednesday, just to derisk a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links should be visually distinct without relying on color
3 participants