Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix session warning banner: visibility and dark theme. #8552

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Feb 10, 2025

  • The session warning banner is displayed when the user session is close to expiry or was expired (on a page that may use the session cookies).
  • This warning banner was broken for a while now, probably because of the change in the disposable banners. Adjusting the z-index to create a temporary fix there.
  • The previous design had a yellow background, but I don't think we need that much color here, using the same background as the disposable banner use seems to be fine.
  • Long-term fix may involve migrating this banner to use the same template and widget location as the disposable banners.
image

--

image

@isoos isoos requested a review from jonasfj February 10, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant