Fixing transformer crash on Null Arrays #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redis return Null Arrays in specific situations (e.g. BLPOP timeouts or EXEC if aborting). Before this commit, _MultiBulkConsumer crashed with a RangeError, while trying to create a List with -1 lenght. Redis doc states: "A client library API should return a null object and not an empty Array when Redis replies with a Null Array". This simple fix does not comply with this suggestion. A larger rework would be required to return a Null object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redis return Null Arrays in specific situations (e.g. BLPOP timeouts or EXEC if aborting).
Before this commit,
_MultiBulkConsumercrashed with a RangeError, while trying to create a List with-1lenght.Redis doc states:
This simple fix does not comply with this suggestion. A larger rework would be required to return a Null object.