Skip to content

Commit

Permalink
Update to work with phoenix_live_dashboard 0.8 (#26)
Browse files Browse the repository at this point in the history 
* Update to work with phoenix_live_dashboard 0.8

* Only phoenix_live_dashboard 0.8 works now

* Change function name

* Fix layout regression
  • Loading branch information
@moxley
moxley authored Jun 28, 2023
1 parent 6f42027 commit 1833f8b
Show file tree
Hide file tree
Showing 3 changed files with 114 additions and 121 deletions.
202 changes: 95 additions & 107 deletions lib/broadway_dashboard.ex
View file
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ defmodule BroadwayDashboard do
end

@impl true
def render_page(assigns) do
def render(assigns) do
if assigns[:error] do
render_error(assigns)
else
Expand All @@ -149,10 +149,22 @@ defmodule BroadwayDashboard do
name: name, render: fn -> render_pipeline_or_error(assigns) end, method: :redirect}
end

nav_bar(items: items)
nav_bar(items: items, page: assigns[:page])
end
end

defp nav_bar(opts) do
assigns = Map.new(opts)

~H"""
<.live_nav_bar id="broadway_navbar" page={@page}>
<:item name={name} :for={{name, item} <- @items}>
<%= item[:render].() %>
</:item>
</.live_nav_bar>
"""
end

defp render_pipeline_or_error(assigns) do
if assigns[:error] do
render_error(assigns)
Expand All @@ -162,108 +174,91 @@ defmodule BroadwayDashboard do
end

defp render_pipeline(assigns) do
row(
components: [
columns(
components: [
pipeline_throughput_row(assigns.stats)
]
),
columns(
components: [
pipeline_graph_row(assigns.layers)
]
)
]
)
~H"""
<.row>
<:col>
<.pipeline_throughput_row stats={@stats} />
<.pipeline_graph_row layers={@layers} />
</:col>
</.row>
"""
end

defp render_error(assigns) do
error_message =
case assigns.error do
:connection_is_not_available ->
"Dashboard is not connected yet."
error_message = error_message(assigns)
assigns = Map.put(assigns, :error_message, error_message)

~H"""
<.row>
<:col>
<.card><%= @error_message %></.card>
</:col>
</.row>
"""
end

:pipeline_not_found ->
"This pipeline is not available for this node."
defp error_message(assigns) do
case assigns.error do
:connection_is_not_available ->
"Dashboard is not connected yet."

:pipeline_is_not_running ->
"This pipeline is not running on this node."
:pipeline_not_found ->
"This pipeline is not available for this node."

:broadway_is_not_available ->
"Broadway is not available on remote node."
:pipeline_is_not_running ->
"This pipeline is not running on this node."

:version_is_not_enough ->
"Broadway is outdated on remote node. Minimum version required is #{@minimum_broadway_version}"
:broadway_is_not_available ->
"Broadway is not available on remote node."

:no_pipelines_available ->
"There is no pipeline running on this node."
:version_is_not_enough ->
"Broadway is outdated on remote node. Minimum version required is #{@minimum_broadway_version}"

:cannot_list_running_pipelines ->
"Could not list running pipelines at remote node. Please try again later."
:no_pipelines_available ->
"There is no pipeline running on this node."

:not_able_to_start_remotely ->
"Could not start the metrics server remotely. Please try again later."
:cannot_list_running_pipelines ->
"Could not list running pipelines at remote node. Please try again later."

{:badrpc, _} ->
"Could not send request to node. Try again later."
end
:not_able_to_start_remotely ->
"Could not start the metrics server remotely. Please try again later."

row(
components: [
columns(
components: [
card(value: error_message)
]
)
]
)
{:badrpc, _} ->
"Could not send request to node. Try again later."
end
end

defp pipeline_throughput_row(stats) do
row(
components: [
columns(
components: [
row(
components: [
columns(
components: [
card(
title: "Throughput",
hint: "Messages p/ second.",
inner_title: "successful",
value: stats.throughput_successful
),
card(inner_title: "failed", value: stats.throughput_failed),
card(
inner_title: "total",
value: stats.throughput_successful + stats.throughput_failed
)
]
)
]
),
row(
components: [
columns(
components: [
card(
title: "All time",
hint: "Messages since start.",
inner_title: "successful",
value: stats.successful
),
card(inner_title: "failed", value: stats.failed),
card(inner_title: "total", value: stats.successful + stats.failed)
]
)
]
)
]
)
]
)
defp pipeline_throughput_row(assigns) do
~H"""
<.row>
<:col>
<.row>
<:col>
<.card title="Throughput" hint="Messages p/ second." inner_title="successful"><%= @stats.throughput_successful %></.card>
</:col>
<:col>
<.card inner_title="failed"><%= @stats.throughput_failed %></.card>
</:col>
<:col>
<.card inner_title="total"><%= @stats.throughput_successful + @stats.throughput_failed %></.card>
</:col>
</.row>
</:col>
<:col>
<.row>
<:col>
<.card title="All time" hint="Messages since start." inner_title="successful"><%= @stats.successful %></.card>
</:col>
<:col>
<.card inner_title="failed"><%= @stats.failed %></.card>
</:col>
<:col>
<.card inner_title="total"><%= @stats.successful + @stats.failed %></.card>
</:col>
</.row>
</:col>
</.row>
"""
end

@hint """
Expand All @@ -276,23 +271,16 @@ defmodule BroadwayDashboard do
processes in red.
"""

defp pipeline_graph_row(layers) do
row(
title: "Graph",
components: [
columns(
components: [
layered_graph(
layers: layers,
title: "Pipeline",
hint: @hint,
background: &background/1,
format_detail: &format_detail/1
)
]
)
]
)
defp pipeline_graph_row(assigns) do
assigns = Map.put(assigns, :hint, @hint)

~H"""
<.row>
<:col>
<.live_layered_graph layers={@layers} id="pipeline" title="Pipeline" hint={@hint} background={&background/1} format_detail={&format_detail/1} />
</:col>
</.row>
"""
end

defp background(node_data) when is_binary(node_data) do
Expand Down
3 changes: 2 additions & 1 deletion mix.exs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,9 @@ defmodule BroadwayDashboard.MixProject do
defp deps do
[
{:broadway, "~> 1.0"},
{:phoenix_live_dashboard, "~> 0.5.1 or ~> 0.6.0 or ~> 0.7.0"},
{:phoenix_live_dashboard, "~> 0.8.0"},
{:phoenix_live_reload, "~> 1.2", only: :dev},
{:phoenix_view, "~> 2.0 or ~> 1.0", only: [:test]},
{:plug_cowboy, "~> 2.0", only: :dev},
{:jason, "~> 1.0", only: [:dev, :test, :docs]},
{:ex_doc, "~> 0.24", only: [:docs], runtime: false},
Expand Down
Loading

0 comments on commit 1833f8b

Please sign in to comment.