-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: abci state sync #2413
base: v2.0-dev
Are you sure you want to change the base?
feat: abci state sync #2413
Changes from 25 commits
2d60300
134855b
c00ecbd
420f84c
1512e85
94777c7
caed905
cacdc8c
c686f27
e6bb363
3b9e2a2
667a3c6
a876678
76a0576
3b80c45
08b7854
a41e993
523dece
9a70f4c
293c71f
1798eb7
0d447ee
b321239
a819364
ad58081
c560323
b38cfe8
143cccc
4d58403
dad9fc2
a8a71d1
6785e6e
3914225
60eb7ff
c16c1d9
58fbd0a
31f7ce4
171c71c
af6fd61
265ce86
6450828
5e9dd01
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,12 @@ ABCI_LOG_STDOUT_FORMAT=pretty | |
ABCI_LOG_STDOUT_COLOR=true | ||
|
||
DB_PATH=/tmp/db | ||
|
||
CHECKPOINTS_PATH=${DB_PATH}/checkpoints | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification The codebase has a proper default production path (
This configuration will lead to data loss on system reboot. Update the environment files to use persistent storage paths instead of 🔗 Analysis chainVerify database paths for production environments. Both Run this script to check if there are any production environment files with similar configuration: Also applies to: 19-19 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for production environment files and their DB_PATH configuration
# to ensure they don't use temporary directories.
echo "Searching for environment files:"
fd -t f "^\.env\.(production|prod)" packages/rs-drive-abci/
echo -e "\nChecking DB_PATH in found files:"
rg "^DB_PATH=" packages/rs-drive-abci/.env.*
Length of output: 702 Script: #!/bin/bash
# Check for deployment documentation and configuration
echo "Searching for deployment-related files and documentation:"
fd -t f "^(deploy|docker|k8s|kubernetes|README)" packages/rs-drive-abci/
echo -e "\nChecking content of found files for database path configuration:"
rg -i "(\bdb[_\s-]path|database[_\s-]path|data[_\s-]dir)" packages/rs-drive-abci/
Length of output: 2638 |
||
|
||
# GroveDB database file | ||
GROVEDB_LATEST_FILE=${DB_PATH}/latest_state | ||
|
||
REJECTIONS_PATH=/tmp/rejected | ||
|
||
# Cache size for Data Contracts | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consolidate checkpoint directory paths.
The ownership command includes a temporary checkpoint directory path (
/var/lib/dash-platform/data/checkpoints
). Once the TODO is addressed, this should be consolidated to use only the${CHECKPOINTS_PATH}
variable.Apply this diff after the drive-abci fix is implemented: