lint: Update depguard configuration #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mjtrangoni please rebase this PR. |
Signed-off-by: Mario Trangoni <[email protected]>
…package.
See,
cmd/upgrade.go:14:2: import 'github.com/pkg/errors' is not allowed from list 'main': Should be replaced by standard lib errors package (depguard)
"github.com/pkg/errors"
^
Signed-off-by: Mario Trangoni <[email protected]>
mjtrangoni
force-pushed
the
fix-depguard
branch
from
4dfe46c to
9fc0b19
Compare
|
@yxxhero done. Thank you! |
|
@mumoshu WDYT? |
mumoshu
reviewed
Jan 13, 2024
yxxhero
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @databus23 @mumoshu,
This update the depguard golangci-lint configuration to the latest state, and update golangi-lint to
1.55.1as well.At the same time, this configuration update pointed out the usage of
github.com/pkg/errors.and I fixed it in a separated commit.
Thank you!
Mario