Add support for --take-ownership parameter #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix databus23#731 Signed-off-by: Guillaume Perrin <[email protected]>
Signed-off-by: Guillaume Perrin <[email protected]>
|
@guillomep nend more tests. |
Signed-off-by: Guillaume Perrin <[email protected]>
|
I added some tests. |
Signed-off-by: Guillaume Perrin <[email protected]>
yxxhero
reviewed
Mar 1, 2025
Signed-off-by: Guillaume Perrin <[email protected]>
|
Do I have any remaining job to do ? |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the new --take-ownership parameter, enabling the tool to detect and report changes in resource ownership by comparing existing release annotations with those from the new release. Key changes include:
- Introducing a new "takeOwnership" flag in the upgrade command and propagating it to related logic.
- Adapting the diff reporting mechanism to include a new OWNERSHIP change style.
- Updating object parsing and merging functions to incorporate ownership differences.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| manifest/util_test.go | Added tests for the deleteStatusAndTidyMetadata function. |
| manifest/util.go | Moved and refactored the deleteStatusAndTidyMetadata function. |
| manifest/parse_test.go | Updated tests for ParseObject with file-read functionality. |
| manifest/parse.go | Added ParseObject function improvements for ownership handling. |
| manifest/generate.go | Removed duplicate implementation of deleteStatusAndTidyMetadata. |
| diff/report.go | Updated report formats to support OWNERSHIP change style. |
| diff/diff_test.go | Added tests for ownership change reporting. |
| diff/diff.go | Introduced OwnershipDiff type and integrated it in diff logic. |
| cmd/upgrade.go | Enhanced upgrade command to handle --take-ownership flag. |
| cmd/helm3.go | Passed the new flag to the underlying helm template flow. |
|
@guillomep no more. latest question: did you test it locally? |
|
Hello, yes I have tested it it looks like this
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I trying to add support of the new
--take-ownershipargument that appears in Helm 3.17.This works by trying to match manifests of the release with existing ones on the cluster. If the release mismatch, then the changing of ownership is displayed in the report.
I have not a lot experience in Go, nor on this project.
Fix #731