Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to sorting column values as numbers #298

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

marijane
Copy link
Contributor

The "exploring numeric columns" section contained the following sentence: "We saw earlier how we can sort column values as numbers, but this does not change the cells in a column from text to numbers. Rather, this interprets the values as numbers for the purposes of sorting but keeps the underlying data type as is"

This episode has covered sorting facet values, but not column values, so this sentence does not make sense here and should be removed to avoid learner confusion.

The "exploring numeric columns" section contained the following sentence: "We saw earlier how we can sort column values as numbers, but this does not change the cells in a column from text to numbers. Rather, this interprets the values as numbers for the purposes of sorting but keeps the underlying data type as is"

This episode has covered sorting facet values, but not column values, so this sentence does not make sense here and should be removed to avoid learner confusion.
@github-actions
Copy link

github-actions bot commented Sep 21, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/OpenRefine-ecology-lesson/compare/md-outputs..md-outputs-PR-298

The following changes were observed in the rendered markdown documents:

 03-exploring-data.md | 2 +-
 md5sum.txt           | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-09-22 07:01:37 +0000

github-actions bot pushed a commit that referenced this pull request Sep 22, 2023
@bencomp
Copy link
Contributor

bencomp commented Sep 22, 2023

Thanks, @marijane! I agree that this can be removed.

@bencomp bencomp merged commit 69f9dbb into datacarpentry:main Sep 22, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 22, 2023
Auto-generated via {sandpaper}
Source  : 69f9dbb
Branch  : main
Author  : Ben Companjen <[email protected]>
Time    : 2023-09-22 20:33:26 +0000
Message : Merge pull request #298 from marijane/patch-1

Remove reference to sorting column values as numbers
github-actions bot pushed a commit that referenced this pull request Sep 22, 2023
Auto-generated via {sandpaper}
Source  : cef77ac
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-09-22 20:34:38 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 69f9dbb
Branch  : main
Author  : Ben Companjen <[email protected]>
Time    : 2023-09-22 20:33:26 +0000
Message : Merge pull request #298 from marijane/patch-1

Remove reference to sorting column values as numbers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants