-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
truncate stdoutput to just action items #208
Open
monrog2
wants to merge
5
commits into
master
Choose a base branch
from
206-trim-stdout-output-to-just-actionable-results-dump-the-rest-into-tgz
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
truncate stdoutput to just action items #208
monrog2
wants to merge
5
commits into
master
from
206-trim-stdout-output-to-just-actionable-results-dump-the-rest-into-tgz
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no pytests were harmed in the making of this PR: |
An alternative is something along the lines of: def prints(objects, sep=' ', end='\n', result="pending"):
with open(RESULT_FILE, 'a') as f:
if result in [FAIL_O, FAIL_UF, MANUAL, ERROR, POST]:
print(objects, sep=sep, end=end, file=sys.stdout)
sys.stdout.flush()
if result != "pending":
print(objects, sep=sep, end=end, file=f)
f.flush()
def print_title(title, index=None, total=None, result="pending"):
if index and total:
end = '\r' if result== "pending" else ''
prints('[Check{:3}/{}] {}... '.format(index, total, title), end=end, result=result)
else:
prints('{:14}{}... '.format('', title), end='')
def print_result(title, result, msg='',
headers=None, data=None,
unformatted_headers=None, unformatted_data=None,
recommended_action='',
doc_url='',
adjust_title=False, index=None, total_checks=None):
padding = 120 - len(title) - len(msg)
if adjust_title: padding += len(title) + 18
output = '{}{:>{}}'.format(msg, result, padding)
if data:
data.sort()
output += '\n' + format_table(headers, data)
if unformatted_data:
unformatted_data.sort()
output += '\n' + format_table(unformatted_headers, unformatted_data)
if data or unformatted_data:
output += '\n'
if recommended_action:
output += '\n Recommended Action: %s' % recommended_action
if doc_url:
output += '\n Reference Document: %s' % doc_url
output += '\n' * 2
if index and total_checks and result in [FAIL_O, FAIL_UF, MANUAL, ERROR, POST]:
print_title(title, index, total_checks, result=result)
prints(output, result=result) and then adding the index/total checks to each print_results treating it as the final write for each check to both stdout is an error, and the file for logging. In both cases, the connections check re-using these functions makes it messy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.