routes/turnilo: allow query params on GET dashs #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves turnilo dashboard routes to a dedicated module.
msune
force-pushed
the
turnilo_get_filter
branch
from
3aae052 to
8960286
Compare
Allow the following query parameters (exact match) on the main GET dashboards URL: * `shortName` * `dataCube` This allows clients to validate whether a unique constrain `shortName+dataCube` is in use and by which dashboard ID. Added test coverage too.
msune
force-pushed
the
turnilo_get_filter
branch
2 times, most recently
from
a0830e9 to
483acf0
Compare
Bump dependencies to latest, to fix an invalid Warning by sqlalchemy
Pass -Werror to pytest so that warnings become errors.
This commit: * Cleans up some left overs from the transition of SQLAlchemy -> SQLModel * Fixes annoying deprecation SQLModel warnings
msune
force-pushed
the
turnilo_get_filter
branch
from
483acf0 to
3505ac0
Compare
|
I think you will like what I piled on top @OscarMoya (yeah, I know, I should have stubbed this in another PR, but there were some conflicts): |
OscarMoya
reviewed
Jun 13, 2024
Make it easy to run within a venv.
Adopt Oscar's suggestion to use a Query class to validate query parameters. Unfortunately, due to the circular dependency, the Query class is moved to services (due to typing). Signed-off-by: Marc Sune <[email protected]> Signed-off-by: Oscar Moya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
routes/turnilo: allow query params on GET dashs
Allow the following query parameters (exact match) on the main GET dashboards URL:
This allows clients to validate whether a unique constrain
shortName+dataCubeis in use and by which dashboard ID.Added test coverage too.