Get-DbaUserPermission - Fix collation conflict (#8367)

dataplat · May 24, 2022 · 277ea60 · 277ea60
1 parent 552a6ae
commit 277ea60
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/bin/stig.sql b/bin/stig.sql
@@ -475,7 +475,7 @@ USE tempdb;
                         P.[Source View]
                     FROM
                         STIG.database_permissions P
-                        INNER JOIN Targets T ON T.[Principal] = P.[Grantee]
+                        INNER JOIN Targets T ON T.[Principal] COLLATE DATABASE_DEFAULT = P.[Grantee] COLLATE DATABASE_DEFAULT
                     ORDER BY
                         P.[Securable Type or Class],
                         P.[Schema/Owner],

diff --git a/tests/Get-DbaUserPermission.Tests.ps1 b/tests/Get-DbaUserPermission.Tests.ps1
@@ -46,4 +46,21 @@ exec sp_addrolemember 'userrole','bob';
             }
         }
     }
+
+    Context "Command do not return error when database as different collation" {
+        $dbName = "dbatoolsci_UserPermissionDiffCollation"
+        $dbCollation = "Latin1_General_CI_AI"
+
+        $null = New-DbaDatabase -SqlInstance $script:instance1 -Name $dbName -Collation $dbCollation
+
+        $results = Get-DbaUserPermission -SqlInstance $script:instance1 -Database $dbName -WarningVariable warnvar
+        It "Should not warn about collation conflict" {
+            $warnvar | Should -Be $null
+        }
+        It "returns results" {
+            $results.Count -gt 0 | Should Be $true
+        }
+
+        $null = Remove-DbaDatabase -SqlInstance $script:instance1 -Database $dbName -Confirm:$false
+    }
 }