Initial F.A.R.R related implementations #106
Conversation
* minor stuff * fix some ciruclar dep issues * restructuring of logging system * lil more resturcturing
| /** | ||
| * @internal | ||
| */ | ||
| export const cloneFLC = <R, RC extends FindLikeCursor, Opts extends GenericFindOptions>(cursor: FindLikeCursor, filter: SerializedFilter, options: Opts, mapping?: (doc: SomeDoc) => R): RC => { |
There was a problem hiding this comment.
Why is this a separate helper function instead of just a clone() method on AbstractCursor?
There was a problem hiding this comment.
Needed a clone function which could override specific cursor attributes anyways, so the no-args .clone() wouldn't do in that situation anywasy
Also, an external helper function has the extra bonus of not encoding specific cursor logic in AbstractCursor (since its parameters depends on the specific cursor's implementation)
- Though I could see it being argued that this is unnecessary since there's no non-find-like cursors anyways
| limit: this._options.limit, | ||
| hybridLimits: this._options.hybridLimits, | ||
| rerankOn: this._options.rerankOn, | ||
| includeScores: true, |
There was a problem hiding this comment.
includeScores should also probably be configurable
There was a problem hiding this comment.
It will be 👍
When includeScores is false, then rerankedResult.scores will just be an empty record.
| /** | ||
| * @internal | ||
| */ | ||
| private async* _iterator(method: string, tm?: TimeoutManager): AsyncGenerator<T, void, void> { |
There was a problem hiding this comment.
_iterator doesn't seem to be necessary, you can easily replace it with a throwIfClosed() method and _next() in toArray() and forEach()
There was a problem hiding this comment.
True but _iterator also has the try-finally which closes the cursor after iteration is done as well
May as well just abstract it into a helper function at that point 🤷
No I have some basic FARR cursor unit tests though here which mostly just tests builder methods & other such properties of the cursor |
No description provided.