forked from faif/python-patterns
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
tested as single file testrun with Python 2.7 only
- Loading branch information
Florian
committed
Apr 4, 2017
1 parent
2464352
commit 882e663
Showing
5 changed files
with
98 additions
and
0 deletions.
There are no files selected for viewing
Empty file.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
#!/usr/bin/python | ||
# -*- coding : utf-8 -*- | ||
import datetime | ||
|
||
""" | ||
Port of the Java example of "Constructor Injection" in | ||
"xUnit Test Patterns - Refactoring Test Code" by Gerard Meszaros | ||
(ISBN-10: 0131495054, ISBN-13: 978-0131495050) | ||
production code which is untestable: | ||
class TimeDisplay(object): | ||
def __init__(self): | ||
self.time_provider = datetime.datetime | ||
def get_current_time_as_html_fragment(self): | ||
current_time = self.time_provider.now() | ||
current_time_as_html_fragment = "<span class=\"tinyBoldText\">" + current_time.hour + ":" + current_time.minute + "</span>" | ||
return current_time_as_html_fragment | ||
""" | ||
|
||
class TimeDisplay(object): | ||
|
||
def __init__(self, time_provider): | ||
self.time_provider = time_provider | ||
|
||
def get_current_time_as_html_fragment(self): | ||
current_time = self.time_provider.now() | ||
current_time_as_html_fragment = "<span class=\"tinyBoldText\">" + current_time + "</span>" | ||
return current_time_as_html_fragment | ||
|
||
class ProductionCodeTimeProvider(object): | ||
""" | ||
Production code version of the time provider (just a wrapper for formatting | ||
datetime for this example). | ||
""" | ||
|
||
def now(self): | ||
current_time = datetime.datetime.now() | ||
current_time_formatted = str(current_time.hour) + ":" + str(current_time.minute) | ||
return current_time_formatted | ||
|
||
class MidnightTimeProvider(object): | ||
""" | ||
Class implemented as hard-coded stub (in contrast to configurable stub). | ||
""" | ||
|
||
def now(self): | ||
current_time_is_always_midnight = "24:01" | ||
return current_time_is_always_midnight |
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
#!/usr/bin/env python | ||
# -*- coding: utf-8 -*- | ||
import unittest | ||
|
||
from dft.constructor_injection import TimeDisplay, MidnightTimeProvider, ProductionCodeTimeProvider, datetime | ||
|
||
""" | ||
Port of the Java example of "Constructor Injection" in | ||
"xUnit Test Patterns - Refactoring Test Code" by Gerard Meszaros | ||
(ISBN-10: 0131495054, ISBN-13: 978-0131495050) | ||
Test code which will almost always fail (if not exactly 12:01) when untestable | ||
production code (production code time provider is datetime) is used: | ||
def test_display_current_time_at_midnight(self): | ||
class_under_test = TimeDisplay() | ||
expected_time = "24:01" | ||
result = class_under_test.get_current_time_as_as_html_fragment() | ||
self.assertEqual(result, expected_time) | ||
""" | ||
|
||
class ConstructorInjectionTest(unittest.TestCase): | ||
|
||
def test_display_current_time_at_midnight(self): | ||
""" | ||
Will almost always fail (despite of right at/after midnight). | ||
""" | ||
time_provider_stub = MidnightTimeProvider() | ||
class_under_test = TimeDisplay(time_provider_stub) | ||
expected_time = "<span class=\"tinyBoldText\">24:01</span>" | ||
self.assertEqual(class_under_test.get_current_time_as_html_fragment(), expected_time) | ||
|
||
def test_display_current_time_at_current_time(self): | ||
""" | ||
Just as justification for working example. (Will always pass.) | ||
""" | ||
production_code_time_provider = ProductionCodeTimeProvider() | ||
class_under_test = TimeDisplay(production_code_time_provider) | ||
current_time = datetime.datetime.now() | ||
expected_time = "<span class=\"tinyBoldText\">" + str(current_time.hour) + ":" + str(current_time.minute) + "</span>" | ||
self.assertEqual(class_under_test.get_current_time_as_html_fragment(), expected_time) | ||
|
||
if __name__ == "__main__": | ||
# PYTHONPATH=$PYTHONPATH:~/ws_github/python-patterns/ | ||
# export PYTHONPATH | ||
# python tests/test_constructor_injection.py | ||
unittest.main() |