Merge pull request #222 from dbmdz/wemi_advanced-errormsg

[METASVC-152] Add detailed error message to WEMI filling procedure
dbmdz · Feb 6, 2025 · e0600e1 · e0600e1
2 parents 527e82b + 6598016
commit e0600e1
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 
 ## Unreleased
 
+### Added
+
+- More detailed error message to WEMI filling procedure
+
 ## [9.5.1](https://github.com/dbmdz/metadata-service/releases/tag/9.5.1) - 2025-01-22
 
 ### Fixed

diff --git a/...z/metadata/server/business/impl/service/identifiable/entity/DigitalObjectServiceImpl.java b/...z/metadata/server/business/impl/service/identifiable/entity/DigitalObjectServiceImpl.java
@@ -373,7 +373,23 @@ private void expandByWemiObjects(DigitalObject digitalObject) throws ServiceExce
         manifestationsWithWorks.parallelStream()
             .filter(m -> Objects.equals(m.getUuid(), item.getManifestation().getUuid()))
             .findFirst()
-            .get(); // must be there otherwise the SQL in getAllManifestationAndWorkUuids is wrong
+            // must be there otherwise the SQL in getAllManifestationAndWorkUuids is wrong
+            .orElseThrow(
+                () ->
+                    new ServiceException(
+                            """
+                  The item's manifestation could not be found although there must be one!
+                  Item: %s;
+                  Manifestation acc. to item: %s;
+                  DigitalObject: %s
+                  """
+                            .formatted(
+                                item.getUuid().toString(),
+                                Optional.ofNullable(item.getManifestation())
+                                    .map(Manifestation::getUuid)
+                                    .map(UUID::toString)
+                                    .orElse("<no UUID in manifestation>"),
+                                digitalObject.getUuid().toString())));
     item.setManifestation(manifestation);
     setNewestLastModified.accept(digitalObject, manifestation);