-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance of delete+insert
incremental strategy with null equality check changes
#834
Improve performance of delete+insert
incremental strategy with null equality check changes
#834
Conversation
Code lgtm, but let's address those failing tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Researched the implications and tests passing. This is judged to be functionally equivalent to the original macro, the performance benefits notwithstanding.
any ideas when this will be available, delete+insert are painfully slow currently |
@jhsb25 should hit Cloud in about a week upper bound, two weeks OSS at current pace unless we had some rollbacks for some reason |
This PR merges the changes for null equality from here: #744 into existing PR: #151
resolves #150
resolves #364
Problem
Solution
Checklist