Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of delete+insert incremental strategy with null equality check changes #834

Merged
merged 4 commits into from
Feb 28, 2025

Conversation

adrianburusdbt
Copy link
Contributor

@adrianburusdbt adrianburusdbt commented Feb 21, 2025

This PR merges the changes for null equality from here: #744 into existing PR: #151

resolves #150
resolves #364

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@VanTudor
Copy link
Contributor

Code lgtm, but let's address those failing tests

@VersusFacit VersusFacit self-requested a review February 28, 2025 12:56
Copy link
Contributor

@VersusFacit VersusFacit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Researched the implications and tests passing. This is judged to be functionally equivalent to the original macro, the performance benefits notwithstanding.

@VersusFacit VersusFacit enabled auto-merge (squash) February 28, 2025 13:02
@VersusFacit VersusFacit disabled auto-merge February 28, 2025 13:02
@VersusFacit VersusFacit merged commit 1bcbfb4 into main Feb 28, 2025
39 checks passed
@VersusFacit VersusFacit deleted the fix-incremental-delete-insert-sql-issue-150 branch February 28, 2025 13:03
@jhsb25
Copy link

jhsb25 commented Feb 28, 2025

any ideas when this will be available, delete+insert are painfully slow currently

@VersusFacit
Copy link
Contributor

VersusFacit commented Mar 3, 2025

@jhsb25 should hit Cloud in about a week upper bound, two weeks OSS at current pace unless we had some rollbacks for some reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes The PR author has signed the CLA
Projects
None yet
6 participants