Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor macro contexts. #9423

Merged
merged 8 commits into from
Jan 23, 2024
Merged

Refactor macro contexts. #9423

merged 8 commits into from
Jan 23, 2024

Conversation

peterallenwebb
Copy link
Contributor

resolves #9422

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@peterallenwebb peterallenwebb requested a review from a team as a code owner January 22, 2024 22:02
@cla-bot cla-bot bot added the cla:yes label Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c547aac) 86.98% compared to head (d8bcfd4) 86.98%.

Files Patch % Lines
core/dbt/contracts/graph/manifest.py 95.55% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9423      +/-   ##
==========================================
- Coverage   86.98%   86.98%   -0.01%     
==========================================
  Files         187      187              
  Lines       24971    25014      +43     
==========================================
+ Hits        21722    21758      +36     
- Misses       3249     3256       +7     
Flag Coverage Δ
integration 84.36% <96.22%> (-0.01%) ⬇️
unit 63.31% <96.22%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterallenwebb peterallenwebb merged commit af18862 into main Jan 23, 2024
50 checks passed
@peterallenwebb peterallenwebb deleted the paw/macro-context-cleanup branch January 23, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Macro Context Cleanup
2 participants