Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add decorator #9427

Merged
merged 2 commits into from
Jan 23, 2024
Merged

add decorator #9427

merged 2 commits into from
Jan 23, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Jan 23, 2024

resolves #9426

Problem

@requires.manifest decorator is missing on retry

Solution

Add the decorator

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@emmyoop emmyoop requested a review from a team as a code owner January 23, 2024 17:46
@emmyoop emmyoop requested a review from ChenyuLInx January 23, 2024 17:46
@cla-bot cla-bot bot added the cla:yes label Jan 23, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c547aac) 86.98% compared to head (93c3b46) 86.98%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9427      +/-   ##
==========================================
- Coverage   86.98%   86.98%   -0.01%     
==========================================
  Files         187      187              
  Lines       24971    25015      +44     
==========================================
+ Hits        21722    21759      +37     
- Misses       3249     3256       +7     
Flag Coverage Δ
integration 84.36% <100.00%> (-0.01%) ⬇️
unit 63.31% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop merged commit cc7170d into main Jan 23, 2024
50 checks passed
@emmyoop emmyoop deleted the er/manifest-decorator branch January 23, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the @requires.manifest decorator to the retry command
2 participants