still register adapter when manifest is provided #9440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
ChenyuLInx
requested review from
gshank,
peterallenwebb and
MichelleArk
and removed request for
martynydbt
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9440 +/- ##
==========================================
+ Coverage 86.76% 87.87% +1.11%
==========================================
Files 185 167 -18
Lines 24321 22170 -2151
==========================================
- Hits 21101 19481 -1620
+ Misses 3220 2689 -531
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MichelleArk
reviewed
Feb 8, 2024
| @@ -277,6 +278,8 @@ def wrapper(*args, **kwargs): | |||
| ctx.obj["manifest"] = parse_manifest( | |||
| runtime_config, write_perf_info, write, ctx.obj["flags"].write_json | |||
| ) | |||
| else: | |||
| register_adapter(runtime_config, get_mp_context()) | |||
There was a problem hiding this comment.
I think we need to add:
adapter = get_adapter(runtime_config)
adapter.set_macro_context_generator(generate_runtime_macro_context)
adapter.set_macro_resolver(ctx.obj["manifest"])to get the tests passing
MichelleArk
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix that we did when backporting a change to 1.7
6e33183#diff-beabcbe3aef83fe254d714ef250f484abd1f1ef314dc9506059eb54a9bfbf9a0R274