Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update contributing expectations for external PR reviews #9451

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Jan 25, 2024

resolves # N/A

Updating CONTRIBUTING.md to provide more clarity on the review process for community-contributed pull requests:

  • ready_for_review triage process
  • response from code reviewers within a week
  • availability in next release after merge

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (50b85a0) 87.92% compared to head (698825a) 87.84%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9451      +/-   ##
==========================================
- Coverage   87.92%   87.84%   -0.09%     
==========================================
  Files         160      160              
  Lines       21934    21934              
==========================================
- Hits        19286    19267      -19     
- Misses       2648     2667      +19     
Flag Coverage Δ
integration 85.30% <ø> (-0.18%) ⬇️
unit 62.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichelleArk MichelleArk added the Skip Changelog Skips GHA to check for changelog file label Jan 25, 2024
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a great update! Just some grammar/repeated sentences.

@MichelleArk MichelleArk requested a review from dbeatty10 January 25, 2024 17:13
MichelleArk and others added 2 commits January 25, 2024 12:14
@MichelleArk MichelleArk marked this pull request as ready for review January 25, 2024 17:24
@MichelleArk MichelleArk requested a review from a team as a code owner January 25, 2024 17:24
@MichelleArk MichelleArk requested a review from gshank January 25, 2024 17:24
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@MichelleArk MichelleArk merged commit bb2017a into main Jan 25, 2024
50 checks passed
@MichelleArk MichelleArk deleted the update-contributing-expectations branch January 25, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants