Refactor DependsOn and MacroDependsOn to use set
#9461
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…build_node_edges` This was necessary after converting the `depends_on.nodes`, `depends_on.macros`, `depends_on_macros`, and `depends_on_nodes` to use sets instead of lists. Doing so unbreaks 9 of the 13 unit tests that got broken on the switch to sets
… use sets This is just a companion commit to previous commit. It isn't strictly necessary, and if it is considered too dangerous, it can be dropped from the PR if need be.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9461 +/- ##
===========================================
- Coverage 87.85% 73.48% -14.38%
===========================================
Files 160 160
Lines 21934 21928 -6
===========================================
- Hits 19271 16113 -3158
- Misses 2663 5815 +3152
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #
Problem
Solution
Checklist