Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pytest-csv from dev-requirements.txt #9473

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Conversation

aranke
Copy link
Member

@aranke aranke commented Jan 29, 2024

resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Jan 29, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3bf148c) 87.93% compared to head (c55ec63) 87.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9473      +/-   ##
==========================================
- Coverage   87.93%   87.87%   -0.07%     
==========================================
  Files         164      164              
  Lines       21965    21967       +2     
==========================================
- Hits        19316    19304      -12     
- Misses       2649     2663      +14     
Flag Coverage Δ
integration 85.34% <100.00%> (-0.14%) ⬇️
unit 62.48% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aranke aranke added the Skip Changelog Skips GHA to check for changelog file label Jan 29, 2024
@aranke aranke requested a review from emmyoop January 29, 2024 14:42
@aranke aranke marked this pull request as ready for review January 29, 2024 14:42
@aranke aranke requested a review from a team as a code owner January 29, 2024 14:42
@aranke aranke requested a review from MichelleArk January 29, 2024 15:08
@aranke aranke merged commit 1cbc6d3 into main Jan 29, 2024
51 checks passed
@aranke aranke deleted the ka/remove_pytest_csv branch January 29, 2024 15:37
Copy link
Contributor

The backport to 1.4.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.4.latest 1.4.latest
# Navigate to the new working tree
cd .worktrees/backport-1.4.latest
# Create a new branch
git switch --create backport-9473-to-1.4.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1cbc6d333d79f4408ed620c5aef18b18a216e6c3
# Push it to GitHub
git push --set-upstream origin backport-9473-to-1.4.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.4.latest

Then, create a pull request where the base branch is 1.4.latest and the compare/head branch is backport-9473-to-1.4.latest.

github-actions bot pushed a commit that referenced this pull request Jan 29, 2024
Copy link
Contributor

The backport to 1.3.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3.latest 1.3.latest
# Navigate to the new working tree
cd .worktrees/backport-1.3.latest
# Create a new branch
git switch --create backport-9473-to-1.3.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1cbc6d333d79f4408ed620c5aef18b18a216e6c3
# Push it to GitHub
git push --set-upstream origin backport-9473-to-1.3.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3.latest

Then, create a pull request where the base branch is 1.3.latest and the compare/head branch is backport-9473-to-1.3.latest.

github-actions bot pushed a commit that referenced this pull request Jan 29, 2024
Copy link
Contributor

The backport to 1.2.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.2.latest 1.2.latest
# Navigate to the new working tree
cd .worktrees/backport-1.2.latest
# Create a new branch
git switch --create backport-9473-to-1.2.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1cbc6d333d79f4408ed620c5aef18b18a216e6c3
# Push it to GitHub
git push --set-upstream origin backport-9473-to-1.2.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.2.latest

Then, create a pull request where the base branch is 1.2.latest and the compare/head branch is backport-9473-to-1.2.latest.

github-actions bot pushed a commit that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants