🐛 zm: Fix generated get_all() function #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naming the optional header parameter 'header' several times for different property getters collides with the 'header` local argument of the generated get_all() function. Obvious workaround is don't name your special parameter 'header'. This is easily fixed by simply wrapping each getter code block generated for get_all() in its own scope.
|
Thanks! |
Just for future ref: This is the benefit of the change, not the summary of the change itself. IMO commit summary should have the later as it makes it easy to see in the log which commit did what. |
Thanks for the lightning-quick review and merge! Also, the commit info suggestion has been noted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naming the optional header parameter 'header' several times for different property getters collides with the 'header` local argument of the generated get_all() function. Obvious workaround is don't name your special parameter 'header'.
This is easily fixed by simply wrapping each getter code block generated for get_all() in its own scope.