Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Make preview SSR only #882

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WIP] Make preview SSR only #882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 33 additions & 2 deletions runtime/fresh/plugin.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,11 @@
import type { AppManifest, SiteInfo } from "@deco/deco";
import { Deco, type PageData, type PageParams } from "@deco/deco";
import { framework as htmxFramework } from "@deco/deco/htmx";
import type { ComponentType } from "preact";
import type { ComponentChildren, ComponentType } from "preact";
import framework from "./Bindings.tsx";
import type { Plugin } from "$fresh/server.ts";
import { renderToString } from "preact-render-to-string";
import { HEAD_CONTEXT } from "$fresh/src/runtime/head.ts";
export type { Plugin } from "$fresh/server.ts";

export interface PluginRoute {
Expand Down Expand Up @@ -65,12 +67,41 @@ export const component = ({ data }: PageParams<PageData>) => {
return <data.page.Component {...data.page.props} />;
};

const adaptRenderOptions = (
render: (data: unknown) => Promise<Response> | Response,
) => {
return (data: PageData) => {
if (data.page.props.options?.serverSideOnly) {
const headContextValue: ComponentChildren[] = [];
// Fill the headContextValue with <Head> from the page.
let res = renderToString(
<HEAD_CONTEXT.Provider value={headContextValue}>
{data.page.Component(data.page.props)}
</HEAD_CONTEXT.Provider>,
);
// Render <Head> to string and add it to the head of the page.
const headContent = headContextValue.map((child) => {
try {
return renderToString(child);
} catch (error) {
console.error("Error rendering to string:", error);
return null;
}
}).filter((content) => content !== null).join("");
res =
`<!DOCTYPE html><html><head><meta charset="utf-8">${headContent}</head>${res}</html>`;
return new Response(res);
}
return render(data);
};
};

export function createFreshHandler<M extends AppManifest = AppManifest>(
deco: Deco<M>,
) {
const h: PluginRoute["handler"] = (req: Request, ctx) => {
return deco.handler(req, {
RENDER_FN: ctx.render.bind(ctx),
RENDER_FN: adaptRenderOptions(ctx.render.bind(ctx)),
GLOBALS: ctx.state.global,
});
};
Expand Down
7 changes: 6 additions & 1 deletion runtime/routes/blockPreview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,12 @@ export const render = async (
return await ctx.render({
page: {
Component: Preview,
props: { url: ctx.var.url, params: ctx.req.param(), data: page },
props: {
url: ctx.var.url,
params: ctx.req.param(),
data: page,
options: { serverSideOnly: true },
},
},
});
} finally {
Expand Down
2 changes: 1 addition & 1 deletion runtime/routes/previews.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export const handler = createHandler((ctx) => {
return ctx.render({
page: {
Component: Preview,
props: {},
props: { options: { serverSideOnly: true } },
},
});
});
Expand Down
Loading