Fix Draftmancer pick breakdown #2606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the first. Add the count of picks of the previous packs to the current index from the draftmancer log, instead of InitialState which is for CubeCobra drafts.
KaelenProctor
commented
Feb 11, 2025
| @@ -142,7 +146,7 @@ const DraftmancerBreakdown: React.FC<BreakdownProps> = ({ draft, seatNumber, pic | |||
| </Flexbox> | |||
| </Col> | |||
| <Col xs={6} sm={8} lg={9} xl={10}> | |||
| <Text semibold lg>{`Pack ${(pack || 0) + 1}: Pick ${pick}`}</Text> | |||
| <Text semibold lg>{`Pack ${pack || 0}: Pick ${pick}`}</Text> | |||
There was a problem hiding this comment.
DraftMancer drafts, unlike CubeCobra drafts, have to break the picks into packs ourselves and the code starts that at 1. CubeCobra packs are arrays starting from zero.
| if (draft.InitialState !== undefined) { | ||
| picks += draft.InitialState[0][i].cards.length; | ||
| } | ||
| picks += picksList[i].length; |
There was a problem hiding this comment.
Sum the picks of the packs before this one. That plus the index within this pack is the overall card index
| } | ||
| } | ||
|
|
||
| if (i === parseInt(pickNumber)) { | ||
| cardsInPack = log[i].booster; | ||
| pick = log[i].pick; |
There was a problem hiding this comment.
log[i].pick is the card index of the overall set of cards, as best I can see
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
Testing
I tested a Draftmancer draft locally in two ways:
Before
As you click through the picks once you get to pack 2 you see the same cards as in pack 1 and the same pick #. Also you can see the pack/pick numbers are all over the place.
After
Now each pack shows the correct cards
And the pick/pack number are accurate
