Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion of Content dynamo model to Typescript #2607

Merged
merged 9 commits into from
Feb 13, 2025

Conversation

KaelenProctor
Copy link
Contributor

@KaelenProctor KaelenProctor commented Feb 12, 2025

Only 5 models left!

Fixes

  1. Minor fix to not write the image object data to dynamo on updates. For articles and videos the imageName string defines the card name/set and the hydration uses that to load the image object from the dictionary
  2. Fix loading more podcast and videos in the Content creator dashboard. Those pages were trying to load more articles which leads to a dynamo error about the predicate not matching the last key cursor

Before

old-failing-to-load-more-content-of-type

After

new-loading-more-content

Regression testing

As a user

  • View Articles list
  • View Article
  • Comment on article
  • View Podcasts list
  • View Podcast and episodes
  • View Videos list
  • View Video
  • Comment on video
  • View latest Content on dashboard
  • Browse content page

As a Content creator

  • View Content creator dashboard to see your content
  • Create article
  • Save article draft
  • Submit article for review
  • Create video
  • Save video draft
  • Submit video for review
  • Create podcast
  • Save podcast draft
  • Submit podcast for review

As an admin

  • Approve and deny content
  • Import podcast episodes via the job podcast sync endpoint

@dekkerglen
Copy link
Owner

Is this ready for review?

@KaelenProctor KaelenProctor marked this pull request as ready for review February 13, 2025 12:20
@KaelenProctor
Copy link
Contributor Author

Is this ready for review?

Yes

@dekkerglen dekkerglen merged commit 73ba69b into dekkerglen:master Feb 13, 2025
1 check passed
@KaelenProctor KaelenProctor deleted the feature/dynamo-6 branch February 14, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants