Added many new table feature reference tables #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrPowers
reviewed
Jan 30, 2024
| @@ -3,12 +3,13 @@ | |||
| from datetime import date, datetime, timedelta | |||
| from decimal import Decimal | |||
| from pathlib import Path | |||
| from typing import Callable, List, Tuple | |||
| from typing import Callable, Tuple, List | |||
There was a problem hiding this comment.
A linter make this change?
MrPowers
approved these changes
Jan 30, 2024
|
|
||
| df.repartition(1).write.format('delta').mode('append').save(case.delta_root) | ||
|
|
||
| delta_table.delete(col("letter") == "a") |
There was a problem hiding this comment.
Maybe append some more rows here so the tests are a little more reliable?
| .execute()) | ||
|
|
||
| df.repartition(1).write.format('delta').mode('append').save(case.delta_root) | ||
| spark.sql(f"ALTER TABLE delta.`{delta_path}` ADD CONSTRAINT const1 CHECK (int > 0);") |
There was a problem hiding this comment.
this is the only way to add a constraint :-) delta-rs though has it part of the builder methods :-D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added reference tables for check-constraints, deletion vectors, column mapping, generated columns, cdf, timestamp with no zone and icebergcompatv1
How was this patch tested?
I ran it locally and inspected the tables for expected output.
Does this require an update to the documentation?