chore: inline format args to improve readability #3154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyurik
requested review from
wjones127,
fvaleye,
roeap,
ion-elgreco,
rtyler and
hntd187
as code owners
github-actions
bot
added
binding/python
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3154 +/- ##
==========================================
+ Coverage 72.14% 72.21% +0.07%
==========================================
Files 143 143
Lines 45692 45599 -93
Branches 45692 45599 -93
==========================================
- Hits 32966 32931 -35
+ Misses 10643 10594 -49
+ Partials 2083 2074 -9 ☔ View full report in Codecov by Sentry. |
nyurik
force-pushed
the
inline-fmt
branch
2 times, most recently
from
ca1d54b to
1329db9
Compare
|
@nyurik can you resolve the conflicts, then we can merge it |
Using this command, fixed format argument inlining to improve readability, and fix a few minor related styling issues like trailing commas in a single line. ``` cargo clippy --all-targets --workspace -- -D clippy::uninlined_format_args ``` Signed-off-by: Yuri Astrakhan <[email protected]>
|
@ion-elgreco thx, done |
ion-elgreco
approved these changes
Feb 22, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this command, fixed format argument inlining to improve readability, and fix a few minor related styling issues like trailing commas in a single line.