feat: enhance ogmios bootstrap #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
verbotenj
commented
Feb 13, 2025
verbotenj
commented
- add extra_annotations for proxy service
- refactor proxy variables
- fix missing image_pull_secret
- condition monitoring because it can be hosted
wolf31o2
approved these changes
Feb 16, 2025
gonzalezzfelipe
requested changes
Feb 27, 2025
bootstrap/variables.tf
Outdated
| # default = 1 | ||
| # } | ||
| // proxy green settings | ||
| variable "proxy_geen_name" { |
There was a problem hiding this comment.
Suggested change
| variable "proxy_geen_name" { | |
| variable "proxy_green_name" { |
bootstrap/main.tf
Outdated
| environment = var.proxy_green_environment | ||
| extension_name = var.extension_name | ||
| extra_annotations = var.proxy_green_extra_annotations | ||
| name = var.proxy_geen_name |
There was a problem hiding this comment.
Suggested change
| name = var.proxy_geen_name | |
| name = var.proxy_green_name |
- add extra_annotations for proxy service - refactor proxy variables - fix missing image_pull_secret - condition monitoring because it can be hosted Signed-off-by: Ales Verbic <[email protected]>
verbotenj
force-pushed
the
feat/enhance-ogmios
branch
from
5b23d47 to
c9097d1
Compare
gonzalezzfelipe
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.