test: remove one of 'node_unit_tests::tls_test' tests #27985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The case above this one seems already testing the same thing (https request using tls.connect). Not sure we should keep this test in this form |
|
(CI passed after reruns..) |
|
How about removing this case, but porting the same case to smoke_test repo? (I can work on that if it sounds ok) |
|
@kt3k totally, that works for me |
bartlomieju
changed the title
bartlomieju
added a commit
that referenced
this pull request
Feb 12, 2025
It will be moved to `npm_smoke_tests` repo instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will be moved to
npm_smoke_testsrepo instead