Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(otel): custom span start + end times are fractional ms #27995

Merged
merged 1 commit into from
Feb 6, 2025
Merged

fix(otel): custom span start + end times are fractional ms #27995

merged 1 commit into from
Feb 6, 2025

Conversation

lucacasonato
Copy link
Member

Previously they were treated as fractional seconds.

@lucacasonato
fix(otel): custom span start + end times are fractional ms
b8df7d9 
Previously they were treated as fractional seconds.
@lucacasonato
Copy link
Member Author

No easy way to test this unfortunately.

crowlKats
crowlKats approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucacasonato lucacasonato merged commit 6619210 into main Feb 6, 2025
18 checks passed
@lucacasonato lucacasonato deleted the fix_custom_span_start_end branch February 6, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crowlKats crowlKats crowlKats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucacasonato @crowlKats