-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to rust 1.85 #28236
base: main
Are you sure you want to change the base?
chore: update to rust 1.85 #28236
Conversation
1835a9d
to
576cf46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4996368
to
b23a5e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dismissing my review. As Divy pointed out, seems like something went wrong rebasing. I recommend not using rebase/force pushing in PRs and instead just use merge commits because it’s easier for people to review updates to PRs.
Updates to use rust 1.85. Doesn't move to the 2024 edition, as that's a fair bit more involved.
A nice side benefit is that the new rustc version seems to lead to a slight reduction in binary size (at least on mac):