Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deno specifier and workspace support #289

Merged
merged 46 commits into from
Aug 30, 2023
Merged

feat: deno specifier and workspace support #289

merged 46 commits into from
Aug 30, 2023

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Aug 30, 2023 •
edited
Loading

This adds initial support for deno: specifiers and resolving deno specifiers to other workspace members.

The name of deno: specifiers is still TBD and same with the registry location.

@dsherret
Saving state for revert
94db638
@dsherret
Slight progress... mostly thinking.
c05ae82
@dsherret
More work.
7ed2454
@dsherret
refactor: remove tuple for pending information
d2c9576
@dsherret
Merge branch 'refactor_remove_tuple_pending_info' into deno_specifiers
e515ae8
@dsherret
Merge branch 'main' into deno_specifiers
71c2980
@dsherret
Update.
6ffe9e7
@dsherret
More progress, but I need to refactor to support lazily retrieving th…
0e79c6b 
…e module content
@dsherret
Further progress.
5c10e91
@dsherret
Add content loading
e25bfb0
@dsherret
More messy work
352a81c
@dsherret
Merge branch 'main' into deno_specifiers
4d6e4b8
@dsherret
Update
29d835a
@dsherret
Start of working
7526675
@dsherret
Updates
6586116
@dsherret
Use module info when loading
a714c10
@dsherret
Consolidate
24d2f15
@dsherret
Load in parallel
23c9bc2
@dsherret
Save
370729f
@dsherret
Maybe fix
b1fbf75
@dsherret
Fix
12894b9
@dsherret
Maybe implement workspace members
8fdabe4
@dsherret
Export
592adf4
@dsherret
Logging
7ee0de7
@dsherret
Update loader interface
fa87c72
@dsherret
Fixes
95aa303
@dsherret
Merge main
609d935
@dsherret
Fix serialization
72f773a
@dsherret
Add build diagnostics and start adding tests
2f7736d
@dsherret
Generalize test builder
3b164ed
@dsherret dsherret mentioned this pull request Aug 30, 2023
Merged
bartlomieju
bartlomieju approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a few nits and questions

src/source.rs Show resolved Hide resolved
tests/helpers/test_builder.rs Outdated Show resolved Hide resolved
src/graph.rs Outdated Show resolved Hide resolved
src/graph.rs Outdated Show resolved Hide resolved
src/graph.rs Show resolved Hide resolved
@dsherret dsherret merged commit 3f6b8ca into denoland:main Aug 30, 2023
3 checks passed
@dsherret dsherret deleted the deno_specifiers branch August 30, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @bartlomieju