fix: speedup slow matching of static routes #1932
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR speeds up matching static file routes. Previously, each static file route would get their own
URLPattern
instance which is slow and we loose the fact that we could do an exact match by doing so.What this PR does is extend the type of a route pattern to be
URLPattern | string
. When it's a string than we treat it as being an exact match and sidestep the whole cost of doing a URL parse + regex match. Note that only we ourselves can create string-based patterns. User supplied patterns are always parsed intoURLPattern
like before.Thanks to @jviide for the idea of adding caching for static routes 👍
In some real world sites I've tested this fix with this reduces route matching cost from
62ms
->0.7ms
Fixes #1931