wip: Add error on lint execution failure #4474
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 8, 2023 08:35
Reports errors on failure to execute linters if `ale_error_on_lint_fail` is set. Bug: It appears the end_lnum is ignored. The scope for an error like this one should likely be the entire file. Please comment at dense-analysis#4060 if having any thoughts at all about this suggested change.
w0rp
requested changes
Mar 8, 2023
There was a problem hiding this comment.
I like the idea of ALE eating its own dog food to use the external sources API itself for showing errors on executable failures. I like also that the setting is off by default.
You could undraft this, add tests for the changes, and add documentation for the new setting.
|
This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for #4060. Feedback is needed.