NuGet test for job file containing invalid JSON throws "Could not load file or assembly 'Microsoft.Build'" exception #11776
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
@brettfo, if the job file contains invalid JSON (e.g. see dependabot/cli#408), the NuGet updater will throw a "Could not load file or assembly 'Microsoft.Build'" exception instead of gracefully returning a
JobErrorBase
object.This PR adds unit tests that reproduce the issue, but I don't know how to fix it as it seems that
Microsoft.Build
is already referenced in the project and it compiles without errors.It looks like these tests pass in the CI pipeline, so maybe it is an environment issue. This issue can be reproduced if run from inside the dependabot-updater-nuget Docker image.
More context in tinglesoftware/dependabot-azure-devops#1548 (comment).
Do you have any suggestions?
Anything you want to highlight for special attention from reviewers?
How will you know you've accomplished your goal?
Checklist