Add grouped updates smoke tests for yarn #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdragon
force-pushed
the
bdragon/yarn-group-rules
branch
2 times, most recently
from
0cb2e5d
to
17bb401
Compare
bdragon
force-pushed
the
bdragon/yarn-group-rules
branch
4 times, most recently
from
20c4c08
to
eb56caf
Compare
bdragon
force-pushed
the
bdragon/yarn-group-rules
branch
from
eb56caf
to
df4ba97
Compare
|
@bdragon any idea if the tests this adds are already covered since you put this up? Or does it still add new ones? I don't mind picking it up to fix merge conflicts and get it across the line, but thought I'd doublecheck with you first to see if you think it's still worth doing since you have more context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds smoke tests for yarn and makes some updates to existing smoke tests along the way.
There's a yarn berry workspaces project in this repo, which led me to think it was being used in the
tests/smoke-yarn-berry-workspaces.yamltest, but in fact the test was actually running against another repo, https://github.com/dsp-testing/dependabot-core-6432. To avoid confusion, I updated the smoke test to use the workspaces project included in this repo (dependabot/smoke-tests).