You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2018. It is now read-only.
I'm not sure if anyone other than us is using the old syntax. The new one feels more robust. We could try to deprecate the old one, or just break it and release a major change if we don't care about maintaining that.
Seems fine to just update the API and do a major release.
It would also be really easy to just map callToImportRegex and callToImportReplace to the new API if they are found in a .soycriticrc.json file, and maybe print a warning to update it.
Currently, we support just one pair
This can be problematic if different types of imports are mixed in the same project, making it really hard to adapt. We could try to
Have synced arrays
Or move this directly to an array of regex,replace pairs
I'm not sure if anyone other than us is using the old syntax. The new one feels more robust. We could try to deprecate the old one, or just break it and release a major change if we don't care about maintaining that.
Thoughts, @Robert-Frampton, @mthadley?
The text was updated successfully, but these errors were encountered: