This repository was archived by the owner on Sep 6, 2018. It is now read-only.
Multiple call to import #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 23, 2017 01:17
carloslancha
force-pushed
the
MultipleCallToImport
branch
from
0b3b1c0 to
5501400
Compare
mthadley
suggested changes
Dec 24, 2017
There was a problem hiding this comment.
@carloslancha These changes are really nice! 👍
Just a few style nitpicks and I think it should be good to go.
src/config.ts
Outdated
| @@ -7,29 +8,40 @@ const CONFIG_FILE_NAMES = [ | |||
| '.soycriticrc.json', | |||
| ]; | |||
|
|
|||
| type CallToImportConfig = { | |||
There was a problem hiding this comment.
Generally, it's better to prefer interfaces over type alias for this kind of thing.
src/config.ts
Outdated
| } | ||
|
|
||
| if (!isRegex(config.callToImportReplace)) { | ||
| throw new Error('callToImportReplace is not a valid replace string.'); | ||
| for (let i=0; i < config.callToImport.length; i++) { |
There was a problem hiding this comment.
Prefer for of over c-style loops:
for (const item of config.callToImport) {
/* ... */
}| } | ||
| ]; | ||
|
|
||
| console.log(chalk.yellow('CONFIG API HAS CHANGED, PLEASE UPDATE\n')); |
src/validate-call-imports.ts
Outdated
| .filter(name => { | ||
| name = transform(name, config.callToImportRegex, config.callToImportReplace); | ||
| return !importNames.find(importName => importName.includes(name)); | ||
| for (let i=0; i < config.callToImport.length; i++) { |
There was a problem hiding this comment.
Same as above, try using a for of instead.
|
Nice job, @carloslancha! /cc @mthadley, since he might not be aware of your latest changes! |
mthadley
approved these changes
Dec 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #13
This pr has two parts:
Btw, first time with Typescript so... be gentle 😛