Merge pull request #94 from stuartleeks/sl/rm-on-run

Add --rm when running the container
devcontainers · Jul 17, 2021 · 9b2e8cc · 9b2e8cc
2 parents 23289aa + 0954028
commit 9b2e8cc
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/azdo-task/DevContainerBuildRun/dist/index.js b/azdo-task/DevContainerBuildRun/dist/index.js
diff --git a/azdo-task/DevContainerBuildRun/dist/index.js.map b/azdo-task/DevContainerBuildRun/dist/index.js.map
diff --git a/common/src/docker.ts b/common/src/docker.ts
@@ -172,7 +172,7 @@ export async function runContainer(
 	const workdir = path.join(workspaceFolder, subFolder)
 	const remoteUser = config.getRemoteUser(devcontainerConfig)
 
-	const args = ['run']
+	const args = ['run', '--rm']
 	args.push(
 		'--mount',
 		`type=bind,src=${checkoutPathAbsolute},dst=${workspaceFolder}`

diff --git a/common_lib/docker.js b/common_lib/docker.js
@@ -164,7 +164,7 @@ function runContainer(exec, imageName, checkoutPath, subFolder, command, envs, m
         const workspaceFolder = config.getWorkspaceFolder(devcontainerConfig, checkoutPathAbsolute);
         const workdir = path_1.default.join(workspaceFolder, subFolder);
         const remoteUser = config.getRemoteUser(devcontainerConfig);
-        const args = ['run'];
+        const args = ['run', '--rm'];
         args.push('--mount', `type=bind,src=${checkoutPathAbsolute},dst=${workspaceFolder}`);
         if (devcontainerConfig.mounts) {
             devcontainerConfig.mounts

diff --git a/github-action/dist/index.js b/github-action/dist/index.js
diff --git a/github-action/dist/index.js.map b/github-action/dist/index.js.map