Add support for Alpine to python feature
#1015
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… package source file
note: the `addgroup` arguments are in a different order than `groupadd`
need to add another clause to handle Alpine; this simplifies the logic for handling both cases
…talled); refactor test script names to remove major version suffix (since it isn't specified in the associated image tag)
samruddhikhandale
requested changes
Jun 25, 2024
disabled by default
guessed by default
note: this change could apply across multiple tests, if desired
`bash` will be installed via "common-utils" feature, so it's not necessary to start from the MCR alpine base image
`bash` will be installed via "common-utils" feature, so it's not necessary to start from the MCR alpine base image
Reduce additional version check/s to only include 3.10 (to save time on testing at the expense of coverage, which we get elsewhere) Co-authored-by: Samruddhi Khandale <[email protected]>
- specify exact alternate version: 3.10.5 - remove checks for 3.8,3.9.13 (now OBE)
…he base image build isn't clean recent version of python:3.12 broke the install test because the APT cache wasn't clean
jonbackhaus
commented
Aug 18, 2024
samruddhikhandale
requested changes
Aug 20, 2024
this is only necessary for distributions like alpine which have a (busybox) shim the previous `--upgrade` flag was not compatible with all package managers; given that alpine does not have the package installed, it can be installed through the `check_packages()` function
| "python": { | ||
| "version": "3.12", | ||
| "toolsToInstall": "ruff,mypy,bandit,pipenv,virtualenv,pytest" | ||
| } | ||
| } | ||
| }, | ||
| "centos-7": { |
There was a problem hiding this comment.
Curious, why was this removed?
There was a problem hiding this comment.
Maybe I misunderstood; I thought you requested this in an earlier comment: #1015 (comment)
Shall I revert the change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support of Alpine Linux to the
pythondev container feature.