Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arch support for common-utils #791

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

openscript
Copy link

This pull requests adds ArchLinux support for the common-utils feature. This comes in handy if you want to set up a ArchLinux devcontainer.

Based on this work it will become possible to add a ArchLinux base image.

@openscript openscript requested a review from a team as a code owner January 4, 2024 15:24
@openscript
Copy link
Author

@microsoft-github-policy-service agree company="openscript GmbH"

@eljog
Copy link
Member

eljog commented Jan 6, 2024

Thank you for the contribution. We will review it soon.
I have approved for the workflow runs.

@eljog
Copy link
Member

eljog commented Jan 16, 2024

We have some failing tests
Could you please take a look at this?

@cappscolton
Copy link

cappscolton commented Jan 19, 2024

Looks like the tests are failing on alpine libssl stuff which was worked on here:
#793

Perhaps the tests just need to be re-run on a checkout with devcontainers:main's latest changes?

@openscript
Copy link
Author

I've updated from upstream. Let's see if the issue is resolved.

Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for taking the time in contributing this PR. This is definitely a value add which will be super helpful for the community 👏

@@ -311,6 +311,53 @@ install_alpine_packages() {
PACKAGES_ALREADY_INSTALLED="true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we bump the minor version for this Feature?

@@ -311,6 +311,53 @@ install_alpine_packages() {
PACKAGES_ALREADY_INSTALLED="true"
}

# Arch Linux packages
install_arch_packages() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -311,6 +311,53 @@ install_alpine_packages() {
PACKAGES_ALREADY_INSTALLED="true"
}

# Arch Linux packages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants