-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add shared
config to build Python shared library
#795
base: main
Are you sure you want to change the base?
add shared
config to build Python shared library
#795
Conversation
@microsoft-github-policy-service agree |
if [ "${SHARED_LIBS}" = "true" ]; then | ||
shared_libs="--enable-shared" | ||
fi | ||
./configure --prefix="${INSTALL_PATH}" --with-ensurepip=install ${config_args} ${shared_libs} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
./configure --prefix="${INSTALL_PATH}" --with-ensurepip=install ${config_args} ${shared_libs} | |
./configure --prefix="${INSTALL_PATH}" --with-ensurepip=install ${config_args} --enable-shared |
Perhaps this is a feature we want by default and no configuration option is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you happen to know the performance consequences of adding --enable-shared
? I suspect that this would be to have as a default (perhaps inverting the option to let us disable) as long as it doesn't significantly increase the (already long) compile time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately I do not, the 'default' Python Docker compilation includes other flags that might improve performance however?
Would you mind adding a scenario test to exercise your new flag (docs)? |
Of course, my bad for missing this. any preference for using an
When not built with shared looks like:
or a Python only
I'll grep either with option with |
I was trying to use this devcontainer with PyInstaller, and it seems like the build fails due to the Python installation not built with the shared libraries.
Summary of Changes
Concerns / Thoughts
Details
Here are the relevant logs