Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support allow list for canister logs in agent-js #965

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

vincent-dfinity
Copy link
Collaborator

@vincent-dfinity vincent-dfinity commented Jan 22, 2025

Description

Support allow list for canister logs in agent-js

  1. Update bin/update-management-idl.ts to use the new URL for ic.did as the old repo has been archived.
  2. Update the declarations.

Fixes # (issue)

SDK-1801

How Has This Been Tested?

Manually ran unit tests and e2e tests.

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

Copy link
Contributor

size-limit report 📦

Path Size
@dfinity/agent 72.09 KB (-0.01% 🔽)
@dfinity/candid 11.65 KB (0%)
@dfinity/principal 4.16 KB (0%)
@dfinity/auth-client 50.09 KB (0%)
@dfinity/assets 67.85 KB (+0.12% 🔺)
@dfinity/identity 47.74 KB (0%)
@dfinity/identity-secp256k1 106.31 KB (+0.14% 🔺)

@vincent-dfinity vincent-dfinity marked this pull request as ready for review January 22, 2025 15:38
@vincent-dfinity vincent-dfinity requested a review from a team as a code owner January 22, 2025 15:38
@krpeacock krpeacock merged commit a469fdc into main Jan 22, 2025
53 checks passed
@krpeacock krpeacock deleted the vincent/SDK-1801 branch January 22, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants