feat: fetch root key before making calls #966
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the root key cannot be fetched inside a synchronous constructor, we should await the root key when the
shouldFetchRootKey
flag is set.This PR adds a guard to the
HttpAgent
async calls to make sure the root key call has finished before making the call. It also modifies some checks forrootKey
in thecanisterStatus
andactor
utils that should instead wait for the call to be completed.This shores up occasional inconsistencies with the agent during local development, and that have affected projects in our examples repostory
Fixes # SDK-1905
How Has This Been Tested?
New tests added to the HttpAgent unit test suite
Checklist: